themagiulio / bandcamp-desktop

Bandcamp Desktop is a crossplatform desktop application. It allows you to use bandcamp.com in an easy and quick way. Keep listening to music while you explore the website.
MIT License
166 stars 8 forks source link

Python Script only build Linux AppImage #31

Closed jjos1 closed 1 year ago

jjos1 commented 2 years ago

Hi. I built the code with your Python Script but not matter what OS selects it always build the Linux AppImage. I'm on MacOs X Mojave. Thanks

themagiulio commented 2 years ago

Hi, thanks for reporting this issue. Apparently there's a problem with the library pynpm if used with versions of Python > 3.7. By the way, at this point you are all set to build the software on your own. You can open the terminal inside the bandcamp-desktop folder and run the command:

npm run-script build --mac

You should find the compiled software inside the dist directory.

This is a temporary solution, I'll try to find a way to fix that.

jjos1 commented 2 years ago

Thanks for the answer. I was also trying to build it manually cloning the repo and using 'npm run-script' as you describe in the Readme but no luck. When I try with the command you suggest I get the following error:

bandcamp-desktop@2.4.0 build electron-builder build -l --publish never

sh: electron-builder: command not found

Any idea?

themagiulio commented 2 years ago

Probably npm is not installing the dev dependencies. Enter in the bandcamp-desktop folder and type: npm install electron electron-builder This should install the missing dependencies.