search

themagiulio / bandcamp-desktop

Bandcamp Desktop is a crossplatform desktop application. It allows you to use bandcamp.com in an easy and quick way. Keep listening to music while you explore the website.
MIT License
172 stars 8 forks source link

Windows Desktop Shortcut Named Incorrectly #4

Closed jeanluchayes closed 4 years ago

jeanluchayes commented 4 years ago

After building the installer, (the exe) from npm and then installing it, it creates a desktop shortcut called:

bandcamp-desktop

Shouldn't it be:

Bandcamp Desktop

bandcamp Desktop

?

jeanluchayes commented 4 years ago

The name of the application on the upper left-hand corner of it is named:

Bandcamp

thus the shortcut should be named

Bandcamp Desktop

I believe

jeanluchayes commented 4 years ago

image

themagiulio commented 4 years ago

Thanks for your help, with the last commit now the mainWindow's title is static. For the other problem, I think I've fixed it by using the productName property, but I'm not sure since I can't build the software at the moment.

jeanluchayes commented 4 years ago

I'll build the windows version and check

jeanluchayes commented 4 years ago

image

verification complete, the Windows icon is correct and so is the title of the App.

You can close this issue.