theman-oj10 / pe

0 stars 0 forks source link

Incorrect NFR #13

Open theman-oj10 opened 2 months ago

theman-oj10 commented 2 months ago

The following is an incorrect NFR: A user should see either a success message which represents a successful execution of a command, or an error message indicating that the command did not execute successfully for any user command supplied by the user. If a command should fail, the underlying person or article data stored in PressPlanner should not be modified in any way not clearly visible to the user, to prevent the user from being oblivious to such changes if needed at all.

The definition of an NFR according to the course website is Functional requirements specify what the system should do. Non-functional requirements specify the constraints under which the system is developed and operated.

In both thee cases, you are specifying what the system should do and as such they would be considered functional requirements.

soc-se-bot commented 2 months ago

Team's Response

Thanks for your input! However, my team would argue that it does constitute an NFR. This is as these requirements focus on error recovery and allowing users to quickly recover from mistakes they made. This falls under quality requirements and accessibility.

Screenshot 2024-04-22 155818.png

As most of our users are journalists who are unlikely to be too familiar with tech, we had included these 2 NFRs related to accessibility and quality to ensure that less experienced users can easily use our app and the app points out errors proactively.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Let's break it down:

"A user should see either a success message which represents a successful execution of a command, or an error message indicating that the command did not execute successfully for any user command supplied by the user."

This statement specifies that the system should display a success message when a command executes successfully or an error message when a command fails. This can be considered a functional requirement as it describes what the system should do in response to user commands.

"If a command should fail, the underlying person or article data stored in PressPlanner should not be modified in any way not clearly visible to the user, to prevent the user from being oblivious to such changes if needed at all."

This statement also contains a functional aspect, which is that the system should not modify the underlying data if a command fails. It specifies the expected behavior of the system in case of a failed command.

Moreover the point about the readers being journalists cannot be considered as NFRs are part of the DG where the readers are developers and this might cause confusion for them.