search

theman-oj10 / pe

0 stars 0 forks source link

Name field doesn't allow for special characters #5

Open theman-oj10 opened 2 months ago

theman-oj10 commented 2 months ago

Names might have special characters like - and / (eg- S/O) and this can be included. It is especially important for this application because the legal names might be required to credit them in articles.

Command Used: add n/Gill s/o bates p/12345678 e/gillbates@sicromoft.com a/Sicromoft HQ Pasted Graphic 1.png 

nus-se-script commented 2 months ago

Team's Response

Both points out validity of characters in names.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Names should allow for common special characters such as /

Screenshot 2024-04-19 at 4.23.27 PM.png

As app was designed for freelance journalists who probably have contacts from around the globe, perhaps it should be allowed for names with characters such as "/" to be allowed when adding persons as the names of some races contain these special characters. This feature should also be extended for adding an article's contributor/interviewee

[original: nus-cs2103-AY2324S2/pe-interim#176] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

As stated in the UG, our app currently only allows name for to be alphanumeric.More importantly / characters are used for prefixes. While this could be a future enhancement our app, we did not however implement it during this iteration to help / characters retain readability as prefixes in commands and given the effort to allow for such a behaviour (S/ and D/ are both valid prefixes for STATUS and DATE, allowing for "S/O" and "D/O" would be confusing both when read in the command line by users and in implementation).

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** The app might be used to store the legal names of contacts to give them credit when writing articles. As such disallowing characters such as / or - can be problematice.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]