search

themaninthesuitcase / gimp-startrail-compositor

36 stars 12 forks source link

Remove pointless timer message #12

Closed berrange closed 5 years ago

berrange commented 5 years ago

Knowing how long an image took to create is not important to users, and it creates an extra dialog box needing dismissing. Displaying this dialog also causes confusion with GIMP 2.10, making it think the plugin has crashed, so displaying another dialog about the (bogus) crash.

PartialVolume commented 5 years ago

It might not be important to you but since when did you speak for all users ?

Personally I like the extra information it gives you, maybe it would be better to fix the confusion with 2.10 rather than completely remove this feature ?

berrange commented 5 years ago

I did debug why the problem was causing gimp to report a crash, but didn't succeed it finding a solution, hence this patch.

PartialVolume commented 5 years ago

Fair enough, these things can be difficult to debug & fix. I'll hopefully take a look at the problem over the next few weeks, unfortunately I'm running Gimp 2.8 (KDE Neon, based on 18.04). Ubuntu 18.10's repository contains Gimp 2.10 so I'll need to run it in VirtualBox to work on it. I don't remember this being an issue in 2.8 but then it's been a while since I used Startrail.

themaninthesuitcase commented 5 years ago

This exists as I found it useful, my laptop is not fast and wasn't then either so I liked knowing how long stuff took when I was iterating to make sure it wasn't getting worse. It was also a sort of prompt for "hey I am done".

Whilst it doesn't really need to be there anymore, calling it pointless is a bit rude and ignores the needs of others. Some may like it.