Improve Dockerfile and Docker compose

themarshallproject / klaxon

Klaxon enables reporters and editors to monitor scores of sites on the web for newsworthy changes.

https://newsklaxon.org

MIT License

646 stars 199 forks source link

Improve Dockerfile and Docker compose #626

Closed duffn closed 1 year ago

duffn commented 1 year ago

This updates Docker usage. This shouldn't change any functionality but only improves and simplifies Docker usage. There are no code changes.

Update Dockerfile, introducing multiple stages, improved layer caching, simplified commands and Ruby 2.7.6
Use .env file by default in compose
Add volume for Postgres in compose so data is not wiped every restart
Add volume for app service in compose so restart is not necessary when code is updated
Add https for local development (experienced authenticity token errors locally without)
Remove now unused compose override file

rdmurphy commented 1 year ago

Hello @duffn — thank you for your contribution!

We just made some significant changes to how Docker works in Klaxon with v0.6.0 so I think much of this doesn't apply anymore. I won't say we're completely done with docker-compose in Klaxon yet, but we'd like to take a step back and figure out what makes the most sense for the project going forward.

As a result I'm gonna close this for now. Thank you again! 🙏