search

themartorana / python-postmark

Postmark library for Python 2.6 and greater
http://davemartorana.com
MIT License
199 stars 83 forks source link

Allow django_backend to take advantage of message_streams #103

Closed hkhanna closed 3 years ago

hkhanna commented 3 years ago

94 allowed the PMMail class to add a message_stream, but this functionality was not provided to the ordinary django_backend. This PR allows a developer to set the message_stream attribute on the EmailMessage instance to use a non-default message stream.

brendanwood commented 3 years ago

Hello, just wanted to bump this PR because we'd like to start using Postmark broadcast streams and can't until this is merged. Happy to help with testing or whatever else is needed to get this merged!

hkhanna commented 3 years ago

Agreed! I'd love to get this merged as well. @themartorana let me know if there is anything you need from me.

nicholasserra commented 3 years ago

Thanks! Sorry for the delay.

Was this manually tested? I'll likely do the same. Think theres a unit test we can add too? Will look more in depth asap.

hkhanna commented 3 years ago

Thanks! Sorry for the delay.

Was this manually tested? I'll likely do the same. Think theres a unit test we can add too? Will look more in depth asap.

Yup, I manually tested it back in August and confirmed it selected the correct stream on Postmark.

hkhanna commented 3 years ago

Added a unit test and made the requested changes. Thanks @nicholasserra! Hope we can get this merged soon.

nicholasserra commented 3 years ago

Thank you :) I'll check this out this week.

nicholasserra commented 3 years ago

Tested LGTM thank you

I'll try to get this out in a new version ASAP