themattinthehatt / behavenet

Toolbox for analyzing behavioral videos and neural activity
https://behavenet.readthedocs.io/
MIT License
57 stars 15 forks source link

Bottleneck error checking breaks on Test Tube grid search #11

Closed yifr closed 4 years ago

yifr commented 4 years ago

I set up n_ae_latents as a list. It gets added to the parser as a 'tunable' argument with options but since it doesn't have a default value, namespace.n_ae_latents gets set to None, and I receive this error:

  File "behavenet/fitting/hyperparam_utils.py", line 83, in add_dependent_params
    * arch_dict['ae_encoding_y_dim'][-1]) < namespace.n_ae_latents:
TypeError: '<' not supported between instances of 'int' and 'NoneType'

This check passes when I set n_ae_latents to a single int, rather than a list.

(Only relevant on develop branch)

themattinthehatt commented 4 years ago

Hey Yoni, this should be fixed on the latest develop branch, but many other changes have taken place in the meantime so you might not want to pull all updates. See the commit here. Basically you can just get rid of this check for now, as it happens in the AE grid search anyways.

yifr commented 4 years ago

Oh, awesome - thank you!