search

themattinthehatt / behavenet

Toolbox for analyzing behavioral videos and neural activity
https://behavenet.readthedocs.io/
MIT License
57 stars 15 forks source link

change msp_weight to msp.alpha in docs and configs #15

Closed cxrodgers closed 4 years ago

cxrodgers commented 4 years ago

I think that the parameter called msp_weight in the docs and example configs is called msp.alpha in the actual code. I don't see msp_weight used anywhere in the actual code. So I'm recommending this doc change. But if this is not right please let me know!

But in any case, without specifying msp.alpha, models of type cond-ae-msp cannot be fit, so the default config file doesn't work out of the box. That's what led me to look into this.

themattinthehatt commented 4 years ago

Yep, you were right - some undocumented refactoring. Thanks for the pull request!