search

themayankjha / JAKYM

JAKYM, Just Another Konsole YouTube-Music. A command line based Youtube music player written in Python with both Spotify and Youtube playlist support and easy on memory. See README for installation instructions.
https://pypi.org/project/jakym/
GNU General Public License v3.0
84 stars 7 forks source link

How to properly exit? #4

Closed lodenrogue closed 3 years ago

lodenrogue commented 3 years ago

I currently using ctrl-c to exit the application. I have to press it twice for some reason (maybe something to do with the threads). Is there a better way to exit?

themayankjha commented 3 years ago

just type 'exit' in the command window. even if the music is playing it will force close the thread that plays music and clean up all the downloaded files.

lodenrogue commented 3 years ago

Typing exit tries to download a song after a song is already playing. Also, I just tried to force quit with ctrl-c and it exited but the song is still playing in the background.

themayankjha commented 3 years ago

this is very strange. I have never had this issue could you provide me with any screenshots? and can you try just calling jakym without python -m jakym and trying it again?

lodenrogue commented 3 years ago

this is very strange. I have never had this issue could you provide me with any screenshots? and can you try just calling jakym without python -m jakym and trying it again?

That worked. I needed to install simpleaudio and run it without python -m. It exits properly now and typing works as expected.

themayankjha commented 3 years ago

Awesome! I am closing this Issue then.

I will work on improving documentation to not include simpleaudio as an optional dependency.