theme-next / hexo-theme-next

Elegant and powerful theme for Hexo.
https://theme-next.org
Other
8.15k stars 2.05k forks source link

Unexpected broken picture appears in sidebar. #975

Closed Liam0205 closed 5 years ago

Liam0205 commented 5 years ago

I agree and want to create new issue


Expected behavior

image

Actual behavior

image

Steps to reproduce the behavior

  1. merge latest commits (#971 ) into local NexT theme directory.
  2. execute hexo s to run local server.
  3. check the side bar.

Node.js and NPM Information

$ node -v && npm -v
v10.13.0
6.4.1

Package dependencies Information

{
  "name": "hexo-site",
  "version": "0.0.0",
  "private": true,
  "hexo": {
    "version": "3.8.0"
  },
  "dependencies": {
    "dtrace-provider": "^0.8.7",
    "hexo": "^3.8.0",
    "hexo-deployer-git": "^0.3.1",
    "hexo-generator-archive": "^0.1.5",
    "hexo-generator-category": "^0.1.3",
    "hexo-generator-feed": "^1.2.2",
    "hexo-generator-index": "^0.2.1",
    "hexo-generator-searchdb": "^1.0.8",
    "hexo-generator-sitemap": "^1.2.0",
    "hexo-generator-tag": "^0.2.0",
    "hexo-renderer-ejs": "^0.3.1",
    "hexo-renderer-marked": "^0.3.2",
    "hexo-renderer-stylus": "^0.3.3",
    "hexo-server": "^0.3.1",
    "hexo-symbols-count-time": "^0.4.4"
  }
}

Hexo Information

Hexo version

$ hexo -v
hexo: 3.8.0
hexo-cli: 1.1.0
os: Windows_NT 6.1.7601 win32 x64
http_parser: 2.8.0
node: 10.13.0
v8: 6.8.275.32-node.36
uv: 1.23.2
zlib: 1.2.11
ares: 1.14.0
modules: 64
nghttp2: 1.34.0
napi: 3
openssl: 1.1.0i
icu: 62.1
unicode: 11.0
cldr: 33.1
tz: 2018e

Hexo Configuration

See #658 .

NexT Information

NexT Version:

NexT Scheme:

Note: I didn't test for other schemes.

NexT Configuration:

See #658 .

Other Information

Browser: Chrome 75.0.3770.142 System: macOS 14, Windows7

jiangtj commented 5 years ago

I can't reproduce. Orz image image What's this? avatar?

Liam0205 commented 5 years ago

@jiangtj

It seems to be a custom logo image.

image

jiangtj commented 5 years ago

image

This maybe work well.

Can you check custom_logo in theme config. image

Liam0205 commented 5 years ago

Hmmmm...

I've figured it out. This is because the incompatibility introduced by #965 . mimi refactored the theme config file, and the relative part of custom_logo was changed from

custom_logo:
  enbale: false
  image: 

to

custom_logo: # invalid path

however, I copied the following snippet into source/_data/next.yml, which eventually causes the problem.

custom_logo:
  enbale: false
  image: 
jiangtj commented 5 years ago

image https://github.com/theme-next/hexo-theme-next/pull/965 Yeah, breaking change in here.

Liam0205 commented 5 years ago

Based on the above discussion, this issue could be closed.

support[bot] commented 5 years ago

:wave: @Liam0205, we use the issue tracker exclusively for bug reports and feature requests. However, this issue appears to be a support request. Please use our support channels to get help with the project.