search

themeblvd / jumpstart

The most extensive WordPress theme for both users and developers from Theme Blvd
http://wpjumpstart.com
GNU General Public License v2.0
5 stars 2 forks source link

Adjust logic for determining brandings icons on frontend #412

Open themeblvd opened 5 years ago

themeblvd commented 5 years ago

When figuring out if an icon is a branding icon, can we disconnect this logic from using the icons.json data file? This makes integrating with the fontawesome exentsion tough because it requires them to implement the data file.

Maybe there could just be a manual list of the branding icons that matches the premium icon list? Maybe we could just implement a second icons.json file from prmium version specifically for a new function that checks for branding icons?

screen shot 2018-11-11 at 9 56 17 am 
/framework/helpers/icons.php
themeblvd commented 5 years ago

The only way around not having the data file is to maintain a list of the brand icons... which will be impossible over time. We need to update the instructions of FA extension to say that the data file is not optional for the reason of these branding icons.