themeblvd / jumpstart

The most extensive WordPress theme for both users and developers from Theme Blvd
http://wpjumpstart.com
GNU General Public License v2.0
5 stars 2 forks source link

Better "align-wide" theme support for block editor, getting rid of old "popout" feature #413

Open themeblvd opened 5 years ago

themeblvd commented 5 years ago

Reference: https://wordpress.org/gutenberg/handbook/extensibility/theme-support/#wide-alignment

Currently support for this is hacky and based off previous "image popout" feature (which was created before WordPress had such a feature). And for styling, we're checking if the page was saved with Gutenberg or not. We should remove the popout option from theme options and handle this better only allowing for alignwide and alignfull, coming from new block editor.

Adding true support for this means we have to change the structure of how the entire content area is wrapped, relative to the entire website's wrapper. Current fullwidth support is done with JavaScript calculating how large to popout the image, relative to the current window size; we should re-work things so that this works with pure CSS.

The biggest current problem with our system is that the user can choose between different "sidebar layouts" -- Combining a full-width block with a sidebar just doesn't really make sense. Could we possibly only make the options in Gutenberg available IF the fullwidth sidebar layout is selected?