themehybrid / hybrid-core

Official repository for the Hybrid Core WordPress development framework.
GNU General Public License v2.0
687 stars 143 forks source link

itemscope attr #106

Closed codesman closed 9 years ago

codesman commented 9 years ago

First off, nice work Justin. Thanks for providing this resource!

I just downloaded the framework to take a look and I noticed that it is giving the itemscope attr a value string of "itemscope". According to http://www.w3.org/TR/microdata/#attr-itemscope, itemscope is a boolean(http://www.w3.org/TR/microdata/#boolean-attribute) and does not take a value string(like checked on checkbox inputs).

I see this a lot in themes out in the wild. Is there a reason why you chose to add the value string?

Tom

justintadlock commented 9 years ago

All three are valid:

<span itemscope>
<span itemscope="">
<span itemscope="itemscope">

I prefer the last method just for my own sanity.

Reference:

codesman commented 9 years ago

Thanks for the clarification!