themehybrid / hybrid-core

Official repository for the Hybrid Core WordPress development framework.
GNU General Public License v2.0
689 stars 144 forks source link

Default branch names #179

Closed justintadlock closed 2 years ago

justintadlock commented 3 years ago

Some of the new repos had a different default branch name than the old ones. That's on me. I should have changed the default for this org but forgot I to do it.

Not to get into the political aspects of "master" vs. "main," I am making a unilateral decision to keep the original "master" branch. Any new repos added will default to that branch too.

My reasoning is purely for consistency. I'm a stickler for maintaining as much consistency as possible across projects. Because our older repos already use that branch name, I would rather stick with it. It's better to go ahead and make a decision for the new repos before they are official.

For now, the "main" branch is still open for those few repos that changed. However, we should remove them pre-6.0 launch. Leaving this ticket open until then.

skyshab commented 3 years ago

I was just reworking my composer file and dealing with this inconsistency.

I don't care if they use main vs master, but consistency would be nice.

saas786 commented 3 years ago

Sure, but I think instead of going back to "master" instead why not use "main" for old repos as well? As though within hybrid theme community it might not be an issue, but later it can be raised by users motivated to go for "main".

That way we can achieve the consistency among repose and also avoid any future discussions on this "master" vs "main" debate.

What's your thoughts on this?

justintadlock commented 3 years ago

It's not going back to master. Most of the repos already use this. The only repos changing are some of the new ones that are not officially in use yet. This causes the least compat, clone updates, etc. issues because there are only about four of us using them right now instead of the hundreds using the older ones.

As for future discussions, I can simply point them to this ticket and close.

saas786 commented 2 years ago

I think should close this one, as technically we have no issue with either master or main branch. And nobody from our community had raised an issue either. So I guess we can close it.