search

themehybrid / hybrid-core

Official repository for the Hybrid Core WordPress development framework.
GNU General Public License v2.0
689 stars 144 forks source link

5.2.1 - Deprecated warnings in PHP 8.1 and 8.2 #196

Open redactuk opened 10 months ago

redactuk commented 10 months ago

I'm in the process of upgrading our barebones template to use hybrid-core v6, but just wanted to report these deprecation notices when using hybrid-core 5.2.1 with PHP 8.1 andf PHP 8.2 in case they are easily fixed for a later temporary 5.2.x

Deprecated: Return type of Hybrid\Container\Container::offsetExists($name) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in C:\laragon\www\wpsredact\wp-content\themes\rscustom\vendor\justintadlock\hybrid-core\src\Container\Container.php on line 486

Deprecated: Return type of Hybrid\Container\Container::offsetGet($name) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in C:\laragon\www\wpsredact\wp-content\themes\rscustom\vendor\justintadlock\hybrid-core\src\Container\Container.php on line 499

Deprecated: Return type of Hybrid\Container\Container::offsetSet($name, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in C:\laragon\www\wpsredact\wp-content\themes\rscustom\vendor\justintadlock\hybrid-core\src\Container\Container.php on line 460

Deprecated: Return type of Hybrid\Container\Container::offsetUnset($name) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in C:\laragon\www\wpsredact\wp-content\themes\rscustom\vendor\justintadlock\hybrid-core\src\Container\Container.php on line 473

Thanks

saas786 commented 10 months ago

@redactuk

Thanks for reporting the issue.

Just an FYI - versions 5 and 6 are considered maintenance releases only. I won't be able to provide extensive support for them. Whenever I have some spare time, I can look into relevant issues, but they are not a top priority for me.

If you need support for PHP 8.1 and above, I recommend using version 7. Any issues related to PHP 8.1+ can be reported for version 7, and I'll be more than happy to address them as soon as possible.

redactuk commented 10 months ago

@saas786 ok that's fine. I wasn't expecting fix, just posted in case a 5.2.x happened for some reason and this was low hanging fruit.

I didn't even realise the was a 7.0 :( Right now I'm prioritising PHP 8.2 so will need to re-evaluate this.