search

themehybrid / mythic

Mythic is a next-generation starter theme designed to help theme authors write elegant, intelligent, and modern code.
https://themehybrid.com/themes/mythic
GNU General Public License v2.0
237 stars 43 forks source link

Integrating the WPThemeReview coding standards #63

Closed justintadlock closed 5 years ago

justintadlock commented 5 years ago

Now that version 0.1.0 of the WPThemeReview project has been tagged, it's time to start discussing adding this to Mythic.

The goal has always been for this to be the default standards shipped with the theme. The timing just wasn't there when we shipped 1.0.0 of Mythic.

They have instructions to follow, so this should be fairly straightforward: https://github.com/WPTRT/WPThemeReview#installing-wpthemereview-as-a-project-dependency

We have a couple of options:

  1. Install this as a dependency (as well as dealerdirect/phpcodesniffer-composer-installer, which is required).
  2. Create a separate coding standards repository/package, which can be managed separately.

It'll probably be better to start with option #1 and move to option #2 if things evolve.

justintadlock commented 5 years ago

And, we've officially got this wrapped up now. I'm super excited that the WP Theme Review standards are built right in! :)