search

themehybrid / mythic

Mythic is a next-generation starter theme designed to help theme authors write elegant, intelligent, and modern code.
https://themehybrid.com/themes/mythic
GNU General Public License v2.0
237 stars 43 forks source link

Adding phpcs.xml file #7

Closed samikeijonen closed 6 years ago

samikeijonen commented 6 years ago

Project code should be checked using PHPCS. In most cases there should be custom phpcs.xml for creating custom ruleset good for project.

Couple of examples:

This way we can also check PHP compatibility for different versions.

samikeijonen commented 6 years ago

I'm pretty happy about the phpcs.xml at the moment.

justintadlock commented 6 years ago

This is probably one of the biggest projects left for the theme before the 1.0.0 release. We need to pay attention to the WPTRT coding standards project. We'll want to take advantage of that and integrate it with any custom rules.

GaryJones commented 6 years ago

Please name it .phpcs.xml.dist, and add phpcs.xml and .phpcs.xml to the .gitignore file.

This allows the distributed config file to be trumped by a local config file.

@samikeijonen I'll add some feedback about your config file, to your repo :-)

justintadlock commented 6 years ago

Closing this specific ticket as fixed. We should open new tickets to address other issues.

In particular, our end goal would be to utilize the WP TRT standards.