search

themehybrid / mythic

Mythic is a next-generation starter theme designed to help theme authors write elegant, intelligent, and modern code.
https://themehybrid.com/themes/mythic
GNU General Public License v2.0
237 stars 43 forks source link

Percent signs are stripped from titles #78

Open armandn opened 5 years ago

armandn commented 5 years ago

If a title contains a percent sign, e.g. "Nasdaq up 25%", the "%" is stripped from the title (only in posts archives, single titles are OK).

It looks like the problem is in functions-post.php, in render_permalink(): there's this code:

    $html = sprintf(
        '<a class="%s" href="%s">%s</a>',
        esc_attr( $args['class'] ),
        esc_url( $url ),
        sprintf( $args['text'], esc_url( $url ) )
    );

I don't understand the purpose of sprintf( $args['text'], esc_url( $url ) ), but replacing it with just $args['text'] seems to fix the problem.

justintadlock commented 5 years ago

Are you posting in the right repository?

Is this something in Hybrid Core? https://github.com/justintadlock/hybrid-core

armandn commented 5 years ago

Yes, sorry, it's Hybrid Core. I forgot that under the hood Mythic uses Hybrid Core that has a separate repo.

armandn commented 5 years ago

Do you want me to post the issue on Hybrid Core and close this one?