search

themekollektiv / popper

Popper is an accessible content-first WordPress theme built around beautiful fonts and lots of white space.
https://wordpress.org/themes/popper/
GNU General Public License v2.0
50 stars 15 forks source link

Formatting and Strict rules. #12

Open bueltge opened 7 years ago

bueltge commented 7 years ago

Hi and thanks a lot for this theme, beautiful.

The question in short:

are pull requests welcome? ;)

More context:

I send you a small pull request, less changes but for bug improvements in the WP world. If you like it, I will send you much more, so that the Theme is much more clean in the code style for WP Codex and php rules for clear and strict coding. Best.

mor10 commented 7 years ago

Some of these edits are great, but I disagree with a lot of others (in particular indentation and comment edits). If you split changes to functionality into a separate pull request I'll consider them.

For the formatting changes (indentation and comments etc) I suggest you try submitting a pull request to the official _S repo (https://github.com/automattic/_s) as that's where much of this originates.

bueltge commented 7 years ago

Hi @mor10 _s have also the same topic, much often no strict coding and difference to the WP Codex. But also I have include changes, like call hooks before the function, there is not a codex rules, is a typical style in the core of WordPress. For the functionality is it no problem. But for readers of source, there work often in the WP Core, environment is it much easier to read always the same style.

_s have currently 50 pull request open, lot of them have the same topic as in your theme. But also open topics for improvements. Like https://github.com/Automattic/_s/pull/1012/commits/9e51c0bc573f1bd01deb91fd29cae703cab64c9d

Also it is not easy to separate the pull request in different request, only via different branches is it possible. But if you don't like it, please close without merge - it is your theme, code. But you can also read the changes, is really small in each commit and ask me. I think you see the benefits if you use code checks, rules like codesniffer or other helpful tools.