themekollektiv / popper

Popper is an accessible content-first WordPress theme built around beautiful fonts and lots of white space.
https://wordpress.org/themes/popper/
GNU General Public License v2.0
50 stars 15 forks source link

Paragraph block with large/extra-large text needs bigger line-height #27

Closed Zodiac1978 closed 3 years ago

Zodiac1978 commented 3 years ago

I have checked Popper with the Gutenberg sample data from this post: https://artisanthemes.io/sample-content-blocks-gutenberg/

And it needs a bigger line-height value for paragraphs with text set to large or extra-large

See this screenshot: Bildschirmfoto 2020-12-27 um 21 11 43

Zodiac1978 commented 3 years ago

The reason for this is the usage of em as unit for line-height in the CSS. https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#Prefer_unitless_numbers_for_line-height_values

After removing the em from the CSS for .site-main (and .site-content) it works correct.