search

themekollektiv / popper

Popper is an accessible content-first WordPress theme built around beautiful fonts and lots of white space.
https://wordpress.org/themes/popper/
GNU General Public License v2.0
50 stars 15 forks source link

Remove em from line-height #34

Closed Zodiac1978 closed 3 years ago

Zodiac1978 commented 3 years ago

Unitless numbers in best practice for line-height values

Fixes #27

bueltge commented 3 years ago

Whether you use the em unit or a pure number is a different issue. Using just a number, as in line-height: 1.2, is primarily equivalent to using the em unit, as in line-height: 1.2em. But there is the difference that when line-height is inherited, it is the pure number that gets inherited, not the computed value. I mean if you use font-size a unit, you should also use them at the line-hight. https://developer.mozilla.org/en-US/docs/Web/CSS/line-height

But I understand this fast solution for the issues with the css classes from Gutenberg. THe easiest and solid way to solve them.

Zodiac1978 commented 3 years ago

if you use font-size a unit, you should also use them at the line-hight.

I don't think you are right here. See the link you posted: https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#prefer_unitless_numbers_for_line-height_values

The example is exactly what happens in Popper.

bueltge commented 3 years ago

Yes, I read them and it is the fastest way to solve the problem. But is not always the best way for the 'Design'. However, I would accept them in the context that we need a solid solution because Gutenberg has to fast changes.

Zodiac1978 commented 3 years ago

I am still not sure what you want to tell me. It is the preferred way to not use units. So why not for the design? I just replaced those which used em and not any of those with pixel. Is this what you mean?

bueltge commented 3 years ago

No. I know that it helps to get always a readable result. But I mean that a unit on the font-size and line-hight is more for the focus to create a Design. Without a unit at the line-height, we get always the result of the browser and haven't any control over the result. Maybe more clear? But not important, your result is fine for me.