themepark-dev / theme.park

A collection of themes/skins for 50 selfhosted apps!
https://theme-park.dev
MIT License
2.43k stars 799 forks source link

Dark themes onedark for Radarr and Jackett is broken. #282

Closed SuberSeb closed 3 years ago

SuberSeb commented 3 years ago

Describe the bug Themes for Radarr and Jackett is broken. For dark theme all is in white colors. But for Sonarr it's fine now.

Theme Install Method (Don't skip)

Application Info (Don't skip)

To Reproduce Just open app.

Expected behavior Dark theme should be applied.

Desktop (If applicable) (please complete the following information):

SuberSeb commented 3 years ago

Same for Sonarr, just recreated the container and it's broken now. Seems that docker mods is not working for some reason.

GilbN commented 3 years ago

See latest release notes https://github.com/GilbN/theme.park/releases/tag/1.6.0

Akirainblack commented 3 years ago

All docker-mods appear broken, even running it with default values. I'm getting stock radarr,sonarr, lidarr and jackett.

jamiew0w commented 3 years ago

See latest release notes https://github.com/GilbN/theme.park/releases/tag/1.6.0

The old folder structure will still be working for the time being, but will be removed in the future.

It appears old setups are broken already though?

For example, all CSS linked here is 404'ing (https://docs.theme-park.dev/themes/radarr/)

338lm commented 3 years ago

See latest release notes https://github.com/GilbN/theme.park/releases/tag/1.6.0

The old folder structure will still be working for the time being, but will be removed in the future.

It appears old setups are broken already though?

For example, all CSS linked here is 404'ing (https://docs.theme-park.dev/themes/radarr/)

this is exactly right. old and new URL's result in a 404 error

GilbN commented 3 years ago

@338lm @jamiew0w Ah right, yes the theme-option files inside each base/themes folder have been removed. You need to take a look at the updated subfilter docs. https://docs.theme-park.dev/setup/#subfilter-method

@SuberSeb @Akirainblack I don't see any issues with docker mods. They have been updated to use the new paths.

You can easily check if your docker_mod is using the latest paths with docker exec radarr cat /etc/cont-init.d/98-themepark

root@Nostromo:~# docker exec radarr cat /etc/cont-init.d/98-themepark
#!/usr/bin/with-contenv bash

echo '---------------------------'
echo '|  Radarr theme.park Mod  |'
echo '---------------------------'

# Display variables for troubleshooting 
echo -e "Variables set:\\n\
'TP_DOMAIN'=${TP_DOMAIN}\\n\
'TP_COMMUNITY_THEME'=${TP_COMMUNITY_THEME}\\n\
'TP_ADDON'=${TP_ADDON}\\n\
'TP_THEME'=${TP_THEME}\\n"

APP_FILEPATH='/app/radarr/bin/UI/index.html'
LOGIN_FILEPATH='/app/radarr/bin/UI/login.html'
if [ "${TP_HOTIO}" = true ]; then
    echo 'Changing to Hotio file path!'
    APP_FILEPATH='/app/bin/UI/index.html'
    LOGIN_FILEPATH='/app/bin/UI/login.html'
fi

# Set default
if [[ -z ${TP_DOMAIN} ]]; then
    echo 'No domain set, defaulting to theme-park.dev'
    TP_DOMAIN='theme-park.dev'
fi

THEME_TYPE='theme-options'
if [ "${TP_COMMUNITY_THEME}" = true ]; then
    THEME_TYPE='community-theme-options'
fi

case ${TP_DOMAIN} in
  *"github.io"*)
  echo "Switching to github.io URL style"
    TP_DOMAIN="${TP_DOMAIN}\/theme.park"
    ;;
esac

if [[ -z ${TP_THEME} ]]; then
    echo 'No theme set, defaulting to organizr'
    TP_THEME='organizr'
fi

# Adding stylesheets
if ! grep -q "${TP_DOMAIN}" "${APP_FILEPATH}"; then
    echo '---------------------------'
    echo '|  Adding the stylesheet  |'
    echo '---------------------------'
    sed -i "s/<\/head>/<link rel='stylesheet' href='https:\/\/${TP_DOMAIN}\/css\/base\/radarr\/radarr-base.css'><\/head> /g" "${APP_FILEPATH}"
    sed -i "s/<\/head>/<link rel='stylesheet' href='https:\/\/${TP_DOMAIN}\/css\/${THEME_TYPE}\/${TP_THEME}.css'><\/head> /g" "${APP_FILEPATH}"
    sed -i "s/<\/head>/<link rel='stylesheet' href='https:\/\/${TP_DOMAIN}\/css\/base\/radarr\/radarr-base.css'><\/head> /g" "${LOGIN_FILEPATH}"
    sed -i "s/<\/head>/<link rel='stylesheet' href='https:\/\/${TP_DOMAIN}\/css\/${THEME_TYPE}\/${TP_THEME}.css'><\/head> /g" "${LOGIN_FILEPATH}"
    printf 'Stylesheet set to %s\n' "${TP_THEME}"
    if [[ -n ${TP_ADDON} ]]; then
        for addon in $(echo "$TP_ADDON" | tr "|" " "); do
        sed -i "s/<\/head>/<link rel='stylesheet' href='https:\/\/${TP_DOMAIN}\/css\/addons\/radarr\/${addon}\/${addon}.css'><\/head> /g" "${APP_FILEPATH}"
        sed -i "s/<\/head>/<link rel='stylesheet' href='https:\/\/${TP_DOMAIN}\/css\/addons\/radarr\/${addon}\/${addon}.css'><\/head> /g" "${LOGIN_FILEPATH}"
        printf 'Added custom addon: %s\n\n' "${addon}"
        done
    fi

And logs from a fresh lsio jackett container:


[mod-init] Attempting to run Docker Modification Logic
[mod-init] Applying gilbn/theme.park:jackett files to container
[s6-init] making user provided files available at /var/run/s6/etc...exited 0.
[s6-init] ensuring user provided files have correct perms...exited 0.
[fix-attrs.d] applying ownership & permissions fixes...
[fix-attrs.d] done.
[cont-init.d] executing container initialization scripts...
[cont-init.d] 01-envfile: executing...
[cont-init.d] 01-envfile: exited 0.
[cont-init.d] 10-adduser: executing...

-------------------------------------
_ ()
| | ___ _ __
| | / __| | | / \
| | \__ \ | | | () |
|_| |___/ |_| \__/

Brought to you by linuxserver.io
-------------------------------------

To support LSIO projects visit:
https://www.linuxserver.io/donate/
-------------------------------------
GID/UID
-------------------------------------

User uid: 99
User gid: 100
-------------------------------------

[cont-init.d] 10-adduser: exited 0.
[cont-init.d] 30-config: executing...
[cont-init.d] 30-config: exited 0.
[cont-init.d] 90-custom-folders: executing...
[cont-init.d] 90-custom-folders: exited 0.
[cont-init.d] 98-themepark: executing...
---------------------------
| Jackett theme.park Mod |
---------------------------
Variables set:
'TP_DOMAIN'=
'TP_COMMUNITY_THEME'=
'TP_THEME'=

No domain set, defaulting to theme-park.dev
No theme set, defaulting to organizr
---------------------------
| Adding the stylesheet |
---------------------------
Stylesheet set to organizr

[cont-init.d] 98-themepark: exited 0.
GilbN commented 3 years ago

@SuberSeb @Akirainblack recreate the container. It doesn't update because the grep is true. And you need the new env for community themes.

GilbN commented 3 years ago

I'll also look into recreating the theme-option files inside each base/themes automatically

GilbN commented 3 years ago

With release of 1.6.1 docker mods should now only need a reboot to get the new paths.

And all the old paths are back.

The /CSS/xxx path will still be removed in the future. So if any of you are using subfiltering you should switch to the new path: /css/base/<app>/<theme-option>.css