themepark-dev / theme.park

A collection of themes/skins for 50 selfhosted apps!
https://theme-park.dev
MIT License
2.43k stars 799 forks source link

Docker Mod Scripts No Longer Backwards Compatible With S6 v2 #441

Closed owine closed 2 years ago

owine commented 2 years ago

Describe the bug Docker Mod scripts are no longer backwards compatible with s6 v2. I am reporting this on Plex, but it would apply to others. I am not sure if there is a good way to make the scripts dually compatible.

Note: This is when using the script files directly (hotio image, PMS official image) rather than the LSIO true mod method

Theme Install Method (Don't skip)

Application Info (Don't skip)

To Reproduce Steps to reproduce the behavior:

  1. Grab 98-themepark script
  2. Mount into container using image built on S6 v2
  3. See error

Expected behavior Expect mod to be applied successfully, but because the #/command/with-contenv bash path does not exist on S6 v2, the script fails to run successfully

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (If applicable) (please complete the following information):

Smartphone (If applicable) (please complete the following information):

Additional context Add any other context about the problem here.

GilbN commented 2 years ago

Are you using the latest tag for hotio?

owine commented 2 years ago

Are you using the latest tag for hotio?

I observed this on the official Plex image.

Another user appeared to be experiencing it on a hotio qbittorrent version pinned to a version prior to the S6 v3 transition.

GilbN commented 2 years ago

I see. I only support Hotio and LSIO. Which uses V3.

You should just use the LSIO container and make your life easier :) You can replace the shebang with #!/usr/bin/with-contenv bash