search

themepark-dev / theme.park

A collection of themes/skins for 50 selfhosted apps!
https://theme-park.dev
MIT License
2.43k stars 799 forks source link

Sonarr, Lidarr, & Prowlarr Theme Issues #499

Closed 1ColdAssHonkey closed 1 year ago

1ColdAssHonkey commented 1 year ago

Describe the bug In the past couple of days, the themes for Sonarr, Lidarr, and Prowlarr have been not completely working. It appears that the devs changed some things on the back-end that effect Theme.Parks custom theming. The themes should color the side bar and top bar, but are not. Please see screenshots below.

Theme Install Method (Don't skip) theme.park-init] Variables set: PUID=99 PGID=100 TZ=America/Los_Angeles TP_DOMAIN=TP_DOMAIN=10.10.20.49\/themepark TP_URLBASE=

Application Info (Don't skip)

To Reproduce Steps to reproduce the behavior:

  1. Load Web Browser
  2. Go to local hosted version of Sonarr, Prowlarr, or Lidarr.

Expected behavior The themes should cover and color the side bar and top bar, but are not. **Radarr is still working** as it should. Thought I surmise it might change soon.

Screenshots Lidarr Sonar Prowlarr

Still Working: Radarr

Desktop (If applicable) (please complete the following information):

Additional context Add any other context about the problem here.

thatbritguy commented 1 year ago

Radarr and the unreleased one also not working on nightly. Prowlarr, Lidarr, Readarr do work for me but those are on develop branch. So it appears it is all current nightly builds that cause theme.park not to apply correctly.

GilbN commented 1 year ago

@1ColdAssHonkey add some Application Info

jpdsc commented 1 year ago

@GilbN my feedback:

Hotio Sonarr (latest v4): 4.0.0.565

Hotio Prowlarr (latest nightly): 1.7.3.3724

Hotio Radarr (latest nightly): 4.7.2.7654

1ColdAssHonkey commented 1 year ago

@GilbN

I am using the nightly versions of each application. Here are the current versions I have.

Sonarr: 4.0.0.565-ls521 by linuxserver.io

Radrr: 4.7.1.7640-ls105 by linuxserver.io

Lidarr: 1.3.2.3377-ls87 by linuxserver.io

Prowlarr: 1.7.3.3724-ls1 by linuxserver.io

GilbN commented 1 year ago

I've pushed some new tags on develop. prowlarr-testing lidarr-testing sonarr-testing radarr-testing

jpdsc commented 1 year ago

I've pushed some new tags on develop. prowlarr-testing lidarr-testing sonarr-testing radarr-testing

I tried pulling sonarr-testing to give it a try but get below error and it doesn't re-create the container: Error response from daemon: No command specified

GilbN commented 1 year ago

They're mods

jpdsc commented 1 year ago

They're mods

My bad, I see now that mods method is being used in this issue. If you want me to test on non-mods let me know and I'm happy to help.

thatbritguy commented 1 year ago

Will these work with the SWAG mod method? Using the testing branch.

GilbN commented 1 year ago

Subfilter should not be affected. Only LSIO mods / hotio scripts

GilbN commented 1 year ago

Will these work with the SWAG mod method? Using the testing branch.

Updated scripts are pushed to develop.

New mods pushed with tag <app>-testing

jpdsc commented 1 year ago

Subfilter should not be affected. Only LSIO mods / hotio scripts

Not sure if this reply was for me but I use subfilter and in Sonarr v4 the layout is broken. image

Majoraslayer commented 1 year ago

To throw in my two cents, I also ran into this issue today when I updated my Docker container for Prowlarr. I'm also using the linuxserver container with subfilter.

image

GilbN commented 1 year ago

Subfilter should not be affected. Only LSIO mods / hotio scripts

Not sure if this reply was for me but I use subfilter and in Sonarr v4 the layout is broken.

Guess we need to do the same fix on subfiltering. Subfilter the body tag instead of the head tag.

proxy_set_header Accept-Encoding "";
sub_filter
'<body>'
'<body><link rel="stylesheet" type="text/css" href="https://theme-park.dev/css/base/$app/$app-base.css">
<link rel="stylesheet" type="text/css" href="https://theme-park.dev/css/theme-options/$theme.css">';
sub_filter_once on;
GilbN commented 1 year ago

To throw in my two cents, I also ran into this issue today when I updated my Docker container for Prowlarr. I'm also using the linuxserver container with subfilter.

If you're using one of the default theme options and nothing custom you can easily switch to docker mods. -e DOCKER_MODS=ghcr.io/gilbn/theme.park:prowlarr-testing -e TP_THEME=aquamarine

Majoraslayer commented 1 year ago

To throw in my two cents, I also ran into this issue today when I updated my Docker container for Prowlarr. I'm also using the linuxserver container with subfilter.

If you're using one of the default theme options and nothing custom you can easily switch to docker mods. -e DOCKER_MODS=ghcr.io/gilbn/theme.park:prowlarr-testing -e TP_THEME=aquamarine

That sorted mine out, thanks!

jpdsc commented 1 year ago

Subfilter should not be affected. Only LSIO mods / hotio scripts

Not sure if this reply was for me but I use subfilter and in Sonarr v4 the layout is broken.

Guess we need to do the same fix on subfiltering. Subfilter the body tag instead of the head tag.

proxy_set_header Accept-Encoding "";
sub_filter
'<body>'
'<body><link rel="stylesheet" type="text/css" href="https://theme-park.dev/css/base/$app/$app-base.css">
<link rel="stylesheet" type="text/css" href="https://theme-park.dev/css/theme-options/$theme.css">';
sub_filter_once on;

Tested with body tag, working as intended, thank you for the help!. Already had a snippet for Pi-hole so I could just re-use that one.

tp-snippet-body.conf

proxy_set_header Accept-Encoding "";
sub_filter
'</body>'
'<link rel="stylesheet" type="text/css" href="$url/css/base/$program/$theme.css">
</body>';
sub_filter_once on;
thatbritguy commented 1 year ago

Changed from to in all my confs for the Starr apps and they are now properly themed again thanks.

Majoraslayer commented 1 year ago

To throw in my two cents, I also ran into this issue today when I updated my Docker container for Prowlarr. I'm also using the linuxserver container with subfilter.

If you're using one of the default theme options and nothing custom you can easily switch to docker mods. -e DOCKER_MODS=ghcr.io/gilbn/theme.park:prowlarr-testing -e TP_THEME=aquamarine

I went through and added this to all of my Starr containers, but I'm having trouble getting it to work on Readarr for some reason. I see a listing for Readarr in the Docker mods, so I'm not sure if there's something wrong with my syntax or what. Below are my env variables and an example. This should also have the now-revised subfilter applied to make sure one or the other should catch it.

image

image

  -e DOCKER_MODS=ghcr.io/gilbn/theme.park:readarr \
  -e TP_THEME=aquamarine \
1ColdAssHonkey commented 1 year ago

Thank you @GilbN, the testing themes worked like a charm!

Will you send out a notice when we can change the theme configs back to the normal ones?

GilbN commented 1 year ago

Will try and make a release this weekend for all *arr mods

GilbN commented 1 year ago

fixed on master