search

themesberg / flowbite-angular

Official Angular components built for Flowbite and Tailwind CSS
https://flowbite-angular.com
Other
189 stars 42 forks source link

feat(ui): Navbar layout, navbar icons and small styling changes #50

Closed ross1296 closed 2 months ago

ross1296 commented 2 months ago

Very small PR, trying to cut my teeth on the project to help out:

Summary by CodeRabbit

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-angular ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 8:42am
coderabbitai[bot] commented 2 months ago

Walkthrough

The changes involve updates to the HTML structure and functionality of various components within the Angular application. Key modifications include the addition of color attributes to sidebar components, enhancements to the navbar with new icon buttons and links, and the introduction of a new NavbarIconButtonComponent and related theming services. The overall styling and responsiveness of the UI have been improved, while existing functionalities remain intact.

Changes

Files Change Summary
apps/docs/src/app/ui/features/docs/docs.component.html Added color attribute to flowbite-sidebar-menu (set to "dark") and flowbite-sidebar-item-group (set to "primary").
apps/docs/src/app/ui/ui.component.html Removed header; enhanced flowbite-navbar with additional navigation items and external links. Integrated branding with navigation items and updated icon buttons for external links. Retained theme toggle and mobile navigation functionalities.
apps/docs/src/app/ui/ui.component.ts Added NavbarIconButtonComponent to imports and declarations.
libs/flowbite-angular/src/lib/common/flowbite.theme.init.ts Introduced theme initialization support for navbar icon buttons, including new theme token and service.
libs/flowbite-angular/src/lib/components/dark-theme-toggle/dark-theme-toggle.component.ts Swapped visibility classes for moon and sun icons to align with theme settings.
libs/flowbite-angular/src/lib/components/navbar/index.ts Added exports for NavbarIconButtonComponent, related types, theme, and service.
libs/flowbite-angular/src/lib/components/navbar/navbar-icon-button.component.ts Introduced NavbarIconButtonComponent with properties for customization and methods for class fetching and verification.
libs/flowbite-angular/src/lib/components/navbar/navbar-icon-button.theme.service.ts Defined a service for managing navbar icon button themes, including a method for merging base and custom styles.
libs/flowbite-angular/src/lib/components/navbar/navbar-icon-button.theme.ts Established theme configuration for navbar icon buttons with defined properties and styles.
libs/flowbite-angular/src/lib/components/navbar/navbar-item.theme.ts Modified text size class in navbarItemTheme to a smaller size.
libs/flowbite-angular/src/lib/components/sidebar/sidebar-menu.theme.ts Changed dark color property in sidebarMenuTheme for improved visual appearance in dark mode.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Navbar
    participant NavbarIconButton
    participant ThemeService

    User->>Navbar: Click on icon button
    Navbar->>NavbarIconButton: Trigger action
    NavbarIconButton->>ThemeService: Get theme classes
    ThemeService-->>NavbarIconButton: Return classes
    NavbarIconButton-->>Navbar: Update appearance

🐰 "In the garden where colors bloom,
New buttons dance, dispelling gloom.
With themes that shift like day to night,
Our navbar shines, a joyful sight!
Hoppity hop, let's celebrate,
A UI bright, oh, isn't it great?" 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
MGREMY commented 2 months ago

@ross1296 Just DM'd you on discord Waiting for your commit and it's good to go 😄

ross1296 commented 2 months ago

@MGREMY Done!

MGREMY commented 2 months ago

@coderabbitai review

coderabbitai[bot] commented 2 months ago
Actions performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.