themesberg / flowbite-react

Official React components built for Flowbite and Tailwind CSS
https://flowbite-react.com
MIT License
1.84k stars 411 forks source link

v0.7.0-beta.5 accidently include sharp as dependency. #1139

Closed BanDroid closed 2 months ago

BanDroid commented 9 months ago

Steps to reproduce

  1. install 0.7.0-beta.5

Current behavior

sharp is not working in termux without using proot or root privileges.

Expected behavior

install flowbite-react just fine.

Context

this is the context.

rluders commented 9 months ago

The suggestion here is to remove it as a dependency and add it during the vercel deployment since it is only used to optimize the documentation.

SutuSebastian commented 9 months ago

The suggestion here is to remove it as a dependency and add it during the vercel deployment since it is only used to optimize the documentation.

I agree that we need to fix this, but could be a bit tedious to do and maintain, I think we should consider splitting the website and the library into separate packages, it is better for the long run and allows isolated package versioning

BanDroid commented 9 months ago

found a temporary solution, only work using pnpm, i dont know if other package manager support this settings in package.json.

"pnpm": {
 "neverBuiltDependencies": ["sharp"]
}

this will ignore running postinstall and build for sharp, because sharp is not needed in the dependency itself.

i will not close this issue yet because the temporary solution is not a full fix for this.

SutuSebastian commented 2 months ago

Fixed in #1264