Open grasdira opened 9 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
flowbite-react | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 4, 2024 1:23pm |
Attention: Patch coverage is 73.91304%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 97.29%. Comparing base (
7461173
) to head (1586050
). Report is 196 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/components/Checkbox/Checkbox.tsx | 73.91% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey thanks for the contribution! I don't have the time to look at this right now but forgive me for jumping in and rebasing, we're trying to figure out what's wrong with codecov. Thank you for your patience! @grasdira
Anyone still working on this?
Anyone still working on this?
Doesn't seem like it 🤔
I'm really sorry for not keeping up with this PR 😔 Since not quite familiar with this project, I need more help to discuss how to solve this problem.
Hi! After rethinking the code, I have made some adjustments to provide developers with more flexibility when using the component:
useRef
to directly set the indeterminate property on the DOM element. This enables the use of the pseudo-class modifiers indeterminate:
in TailwindCSS for CSS customization. (@SutuSebastian sorry for taking so long to reply, this point is why I don't think data-...
is a better way on this feature. ).css
files, realizing that this approach was limiting the developers’ ability to change the icon or other styles for the indeterminate state. (https://github.com/themesberg/flowbite-react/pull/1155/commits/90ec304ff705e76d7bb30d729df1c409f450076f)tailwind.config.ts
, I have extended indeterminate backgroundImage
(https://github.com/themesberg/flowbite-react/pull/1155/commits/a4af18f22c8735ea21630319064efc6bee1df8d0) and set the CSS for the indeterminate checkbox with indeterminate:
modifier in Checkbox.tsx
(https://github.com/themesberg/flowbite-react/pull/1155/commits/a1bfc2134cbfb233f51b49cf5372bf788973ceef).What are your opinions on these changes?
Start from the discussion #870
Related to #871
There are no breaking API changes. Here are my changes:
To ensure that checkboxes with an indeterminate state display the correct style, this commit(https://github.com/themesberg/flowbite-react/commit/65e9f8bbfeb395999ccfd63cd21c606a2a181a5d) added the following CSS in both
.storybook/style.css
anddocs.css
to override the default styles:This commit(https://github.com/themesberg/flowbite-react/commit/f1a847874af3ce786e3d04fd189273f146e31276) added a new example of using the indeterminate state to handle multiple checkboxes in a group or tree structure.