themesberg / flowbite-react

Official React components built for Flowbite and Tailwind CSS
https://flowbite-react.com
MIT License
1.84k stars 411 forks source link

`<Checkbox>` doesn't have outline in dark mode #1159

Closed tulup-conner closed 9 months ago

tulup-conner commented 9 months ago

Steps to reproduce

  1. Create any <Checkbox />
  2. Switch to dark mode
  3. Click on it

Current behavior

The checkbox is surrounded by a thick layer of blue.

Expected behavior

There should be a small (~2px) gap between the edge of the checkbox itself and the blue border around it. I believe the box model term for this space is the outline.

Context

Reproducible in the live docs: https://www.flowbite-react.com/docs/components/forms#checkbox Correct behavior: https://flowbite.com/docs/forms/checkbox/#checkbox-example

gramzanali-scottlogic commented 9 months ago

Hi, I'm looking to make a first contribution to an open source project. Can I have a go at fixing this issue?

mud1tx commented 9 months ago

@tulup-conner I can give this issue a try. Can you please assign it to me.

tulup-conner commented 9 months ago

@gramzanali-scottlogic @mud1tx You are always welcome to submit a PR and reference this issue within it. You don't need to ask permission :)

mud1tx commented 9 months ago

@tulup-conner earlier it looks like this Screenshot from 2023-12-01 11-34-25

now it is looking like this Screenshot from 2023-12-01 11-32-57

is this works or I have to do some changes?

tulup-conner commented 9 months ago

That looks right at first glance! You should check out the official vanilla Flowbite library docs to check that anything you're working on. For Checkboxes, that's https://flowbite.com/docs/forms/checkbox/#checkbox-example

mud1tx commented 9 months ago

@tulup-conner I went through the docs and that checkbox is working please give it a look.