Closed nikitadubyk closed 1 month ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
flowbite-react | ❌ Failed (Inspect) | Apr 28, 2024 4:43pm | ||
flowbite-react-storybook | ❌ Failed (Inspect) | Apr 28, 2024 4:43pm |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.36%. Comparing base (
7461173
) to head (3311292
). Report is 245 commits behind head on main.:exclamation: Current head 3311292 differs from pull request most recent head e67ddac. Consider uploading reports for the commit e67ddac to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@SutuSebastian can you please check my pr?
Latest commit: e67ddacbc579a5699a9583bc196208ee324a5c54
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The recent updates focus on enhancing the ToggleSwitch
component by adding a new story for testing long labels and updating styling to handle multi-line labels effectively. These changes aim to improve the component's responsiveness and visual integrity across different devices and scenarios.
Files | Change Summary |
---|---|
.../ToggleSwitch/ToggleSwitch.stories.tsx |
Added ToggleSwitchWithLongLabel story to test long labels. |
.../ToggleSwitch/theme.ts |
Updated toggle base style and sizes to better support long labels and prevent style collapsing. |
Objective | Addressed | Explanation |
---|---|---|
Ensure ToggleSwitch styling remains intact on mobile with long labels (#884, #587) | ✅ | |
Prevent ToggleSwitch from collapsing when label spans multiple lines (#884, #587) | ✅ |
🐰🌟 In the realm of UI so bright, A ToggleSwitch now holds the light. Long labels stretch, but do not break, Through screens small, a path they make. CodeRabbit hops with joy, you see, For styled toggles as they should be! 🌟🐰
src/components/ToggleSwitch/theme.ts (2)
`13-13`: Ensure the `relative shrink-0` classes are visually verified. Nikitadubyk's comment suggests potential issues without `shrink-0`. Please confirm the component's appearance with these classes, possibly referencing the linked visual evidence. --- `38-40`: Adjustments to the `min-w-` classes in sizes are appropriate. These changes should help maintain the visual integrity of the `ToggleSwitch` across different device sizes, as intended.
@SutuSebastian sorry for late update) I fix comments now
deprecated by #1428
Fixed display of component with large label on mobile devices
fix #884 and fix #587
Fixed the display of the component with a large label on mobile devices. Now it does not collapse and is displayed correctly
https://github.com/themesberg/flowbite-react/issues/587 https://github.com/themesberg/flowbite-react/issues/884
Summary by CodeRabbit
New Features
ToggleSwitch
component with a new story for testing long labels.Style Updates
ToggleSwitch
component styles to improve layout and sizing across small, medium, and large sizes.