Open DavidSeptimus-Klotho opened 7 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
flowbite-react | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jan 17, 2024 0:49am |
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
7461173
) 99.54% compared to head (76132ab
) 97.37%. Report is 186 commits behind head on main.:exclamation: Current head 76132ab differs from pull request most recent head b379544. Consider uploading reports for the commit b379544 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I understand the practical appeal, but this functionality isn't available in the upstream library at flowbite.com, so I'm not sure if we should add it here.
@zoltanszogyenyi I defer to you on this one - it seems like this would be a useful feature, and it's also pretty difficult to create a wrapper of our component to achieve this. You would probably be forced to patch flowbite-react to do so.
It looks like the upstream has support for trigger="none"
and exposes show()
, hide()
, and toggle()
functions for custom triggers. It just seems kind of wasteful to have to reimplement delay when it's supported by the underlying floating-ui implementation.
Nice one! It only needs re-build since we now have new monorepo structure (see #1264).
If u feel like u don't have the time, I can take it from here, just let me know! 🤝
@SutuSebastian I doubt I'll have time for this in the near-term. Feel free to pick it up if you'd like.
implements #589
This change adds support for floating-ui's
useHover
restMs
anddelay
props to theTooltip
component to enable delayed opening/closing of tooltips.