themesberg / flowbite-react

Official React components built for Flowbite and Tailwind CSS
https://flowbite-react.com
MIT License
1.82k stars 406 forks source link

enhancement: checkbox and radio components with 'disabled:cursor-not-allowed' #1212

Closed abdulbasithqb closed 6 months ago

abdulbasithqb commented 7 months ago

Enhance Checkbox and Radio Styling

Changes:

Improve styling for checkbox and radio components by adding a 'disabled' look with a non-interactive cursor.

Why:

Enhances user experience by clearly indicating the disabled state. Prevents unintended interactions with disabled checkboxes and radio buttons.

Screenshots:

https://github.com/themesberg/flowbite-react/assets/134603758/72b1d410-6e0d-421f-be7c-97e17a7539f1

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 4:24pm
codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7461173) 99.54% compared to head (3692669) 97.38%. Report is 193 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1212 +/- ## ========================================== - Coverage 99.54% 97.38% -2.17% ========================================== Files 163 216 +53 Lines 6621 9217 +2596 Branches 401 538 +137 ========================================== + Hits 6591 8976 +2385 - Misses 30 241 +211 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tulup-conner commented 7 months ago

Personally, I agree with this decision but it's not in the main library (https://flowbite.com/docs/forms/checkbox/#disabled-state) @zoltanszogyenyi Is this something we'd be interested in universally for Flowbite?

rluders commented 6 months ago

@abdulbasithqb it is important that instead of 'merge' the main with your branch, you rebase it, so it would not break the git history.

abdulbasithqb commented 6 months ago

@abdulbasithqb it is important that instead of 'merge' the main with your branch, you rebase it, so it would not break the git history.

Hey, new PR raised PR #1255