themesberg / flowbite-react

Official React components built for Flowbite and Tailwind CSS
https://flowbite-react.com
MIT License
1.78k stars 396 forks source link

Feature/carousel active slide #1214

Open cristiantiradob opened 6 months ago

cristiantiradob commented 6 months ago

Added 'activeSlide' prop with tests and docs. I considered the following facts:

Fixes #1094

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 10:25pm
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7461173) 99.54% compared to head (70f7db3) 97.36%. Report is 184 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1214 +/- ## ========================================== - Coverage 99.54% 97.36% -2.18% ========================================== Files 163 214 +51 Lines 6621 9085 +2464 Branches 401 532 +131 ========================================== + Hits 6591 8846 +2255 - Misses 30 239 +209 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shippinglob commented 3 months ago

Hi. I'm not one of the maintainer of this repository but thanks for implementing this very useful update. I went over the PR and It LGTM. Only a minor comment for :

navigateTo(validateActiveSlide)();

In the case of an invalid index, I prefer keeping the current active item as it makes debugging issues easier.