feat: Popover component

themesberg / flowbite-react

Official React components built for Flowbite and Tailwind CSS

https://flowbite-react.com

MIT License

1.78k stars 396 forks source link

feat: Popover component #1237

Closed nigellima closed 5 months ago

nigellima commented 5 months ago

[x] I have followed the Your First Code Contribution section of the Contributing guide

Summarize the changes made and the motivation behind them. This PR creates the Popover component based on the specs of the core library. It also gets some examples from there

Reference related issues using # followed by the issue number. fix #916 fix #878

This also impacts https://github.com/themesberg/flowbite-react/pull/1095. The user will be able to build their own form structures inside Popovers without facing the a11y issues with typehead in Dropdowns

If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
flowbite-react	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 22, 2024 11:08pm

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7461173) 99.54% compared to head (7c7c508) 97.38%. Report is 188 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1237 +/- ## ========================================== - Coverage 99.54% 97.38% -2.16% ========================================== Files 163 217 +54 Lines 6621 9225 +2604 Branches 401 538 +137 ========================================== + Hits 6591 8984 +2393 - Misses 30 241 +211 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joaozitopolo commented 4 months ago

this component is documented as ready, but it's not present on last version (0.7.2). I think the documentation should reflect only usable components

SutuSebastian commented 4 months ago

this component is documented as ready, but it's not present on last version (0.7.2). I think the documentation should reflect only usable components

The next version of this repo (switching it to monorepo) will include a better way to have a 1-to-1 docs<->npm correlation.