Closed dhavalveera closed 3 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
flowbite-react | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 15, 2024 8:53am |
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
7461173
) 99.54% compared to head (86ea8d8
) 97.32%. Report is 195 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
another push of the code changes includes the position of the Drawer (top
| right
| bottom
| left
), where default one is left
@dhavalveera when I test the example in the docs the drawer is displayed outside the example, covering the documentation left sidebar. My best guess here is that isn't desirable, right?
@dhavalveera when I test the example in the docs the drawer is displayed outside the example, covering the documentation left sidebar. My best guess here is that isn't desirable, right?
Yes @rluders it's not desirable, but I'm not sure how avoid this, maybe change the position or something, would it be possible @rluders Sir, please guide me? 🙏
Yes @rluders it's not desirable, but I'm not sure how avoid this, maybe change the position or something, would it be possible @rluders Sir, please guide me? 🙏
TBH, I have no idea. :)
@SutuSebastian , I've tried your suggestion as per shared in Discord Channel, by adding the position: relative
to the Code Demo Wrapper Code and adding the position: absolute
to the Drawer Code, and it worked, as well as I tried to check the Modal & Popover code in my local, and it seems working for me, can you please have a look from the above deployed Vercel Link, please 🙏
@dhavalveera would it be possible to have a slide transition? like, when it's left-right it would be cool to have it slide over from outside of the screen instead of just popping up instantaneously
@dhavalveera would it be possible to have a slide transition? like, when it's left-right it would be cool to have it slide over from outside of the screen instead of just popping up instantaneously
OK, can you try to help me on this, if possible? @nigellima
Hello @SutuSebastian , Sorry to bother you, but can you please help me in this PR?
Thank you @dhavalveera for getting this started! I just opened a new PR branching off your changes at #1342 and added credits pointing directly to your original work here. I'm going to go ahead and close this PR since all remaining work will be conducted there.
feat(drawer): created Drawer component
This PR creates the Drawer component based on the specs of the core library
docs(Drawer): created document page of Drawer component with examples
docs(Drawer): improved documentation