themesberg / flowbite-react

Official React components built for Flowbite and Tailwind CSS
https://flowbite-react.com
MIT License
1.78k stars 396 forks source link

feat: Drawer component #1265

Closed dhavalveera closed 3 months ago

dhavalveera commented 5 months ago
vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 8:53am
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7461173) 99.54% compared to head (86ea8d8) 97.32%. Report is 195 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1265 +/- ## ========================================== - Coverage 99.54% 97.32% -2.23% ========================================== Files 163 222 +59 Lines 6621 9487 +2866 Branches 401 548 +147 ========================================== + Hits 6591 9233 +2642 - Misses 30 254 +224 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dhavalveera commented 5 months ago

another push of the code changes includes the position of the Drawer (top | right | bottom | left), where default one is left

rluders commented 5 months ago

@dhavalveera when I test the example in the docs the drawer is displayed outside the example, covering the documentation left sidebar. My best guess here is that isn't desirable, right?

image

dhavalveera commented 5 months ago

@dhavalveera when I test the example in the docs the drawer is displayed outside the example, covering the documentation left sidebar. My best guess here is that isn't desirable, right?

image

Yes @rluders it's not desirable, but I'm not sure how avoid this, maybe change the position or something, would it be possible @rluders Sir, please guide me? 🙏

rluders commented 5 months ago

Yes @rluders it's not desirable, but I'm not sure how avoid this, maybe change the position or something, would it be possible @rluders Sir, please guide me? 🙏

TBH, I have no idea. :)

dhavalveera commented 5 months ago

@SutuSebastian , I've tried your suggestion as per shared in Discord Channel, by adding the position: relative to the Code Demo Wrapper Code and adding the position: absolute to the Drawer Code, and it worked, as well as I tried to check the Modal & Popover code in my local, and it seems working for me, can you please have a look from the above deployed Vercel Link, please 🙏

nigellima commented 5 months ago

@dhavalveera would it be possible to have a slide transition? like, when it's left-right it would be cool to have it slide over from outside of the screen instead of just popping up instantaneously

dhavalveera commented 5 months ago

@dhavalveera would it be possible to have a slide transition? like, when it's left-right it would be cool to have it slide over from outside of the screen instead of just popping up instantaneously

OK, can you try to help me on this, if possible? @nigellima

dhavalveera commented 4 months ago

Hello @SutuSebastian , Sorry to bother you, but can you please help me in this PR?

tulup-conner commented 3 months ago

Thank you @dhavalveera for getting this started! I just opened a new PR branching off your changes at #1342 and added credits pointing directly to your original work here. I'm going to go ahead and close this PR since all remaining work will be conducted there.