search

themesberg / flowbite-react

Official React components built for Flowbite and Tailwind CSS
https://flowbite-react.com
MIT License
1.77k stars 395 forks source link

docs(remix): added additional notes for using Remix Link API #1280

Open dhavalveera opened 4 months ago

dhavalveera commented 4 months ago

if we are using Remix API Layer Link from @remix-run/react, and using it == as={Link} then replace the href with to, and we can use href if we are not using Link on Navbar.Link & Sidebar.Item

stackblitz[bot] commented 4 months ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 11:00am
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.35%. Comparing base (7461173) to head (3657feb). Report is 195 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1280 +/- ## ========================================== - Coverage 99.54% 97.35% -2.20% ========================================== Files 163 216 +53 Lines 6621 9224 +2603 Branches 401 538 +137 ========================================== + Hits 6591 8980 +2389 - Misses 30 244 +214 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dhavalveera commented 3 months ago

Hello @SutuSebastian , Sorry to bother you, but can you please review this PR?

dhavalveera commented 3 months ago

can we simplify the text a bit? so its more concise and easier to understand

I wrote this explanation with examples for better understanding. but let me try if I can simplify the text. @SutuSebastian

SutuSebastian commented 3 months ago

Actually, let's wait with this since we'll have a new way of making navigation more friendly and top level config, so the developer doesn't have to repeat itself in all places.

Logic behind: register once -> it just works.

dhavalveera commented 3 months ago

Actually, let's wait with this since we'll have a new way of making navigation more friendly and top level config, so the developer doesn't have to repeat itself in all places.

Logic behind: register once -> it just works.

Sounds Great!.. I would be happy to help you & contribute with you more on this.

dhavalveera commented 3 months ago

Actually, let's wait with this since we'll have a new way of making navigation more friendly and top level config, so the developer doesn't have to repeat itself in all places.

Logic behind: register once -> it just works.

can I close this PR? @SutuSebastian

SutuSebastian commented 3 months ago

Actually, let's wait with this since we'll have a new way of making navigation more friendly and top level config, so the developer doesn't have to repeat itself in all places. Logic behind: register once -> it just works.

can I close this PR? @SutuSebastian

keep it for a while, so we can close it with reference.