themesberg / flowbite-react

Official React components built for Flowbite and Tailwind CSS
https://flowbite-react.com
MIT License
1.77k stars 395 forks source link

feat(skeleton): added Skeleton Loading with Examples #1296

Closed dhavalveera closed 3 months ago

dhavalveera commented 3 months ago

This Pull Request introduces Skeleton Loading components to Flowbite-React, leveraging the Flowbite package. Skeleton Loading provides users with a seamless loading experience by displaying placeholders while content is being fetched or loaded. This enhancement includes various Skeleton components such as Skeleton, Skeleton Video, Skeleton Image, Skeleton Card, Skeleton List, and Skeleton Testimonial, ensuring a consistent loading UI across different types of content. With these additions, users will enjoy smoother transitions and improved usability, enhancing the overall user experience of Flowbite-React applications.

Pardon me for the variable names, please suggest a better naming convention.

stackblitz[bot] commented 3 months ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 10:06am
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.70%. Comparing base (7461173) to head (1711807). Report is 201 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1296 +/- ## ========================================== - Coverage 99.54% 95.70% -3.85% ========================================== Files 163 225 +62 Lines 6621 10048 +3427 Branches 401 560 +159 ========================================== + Hits 6591 9616 +3025 - Misses 30 432 +402 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dhavalveera commented 3 months ago

on dark mode the root skeleton doesn't seem to work properly:

Screenshot 2024-03-13 at 15 42 53

also, for the skeleton examples (image, video, card, list, testimonial) i was thinking of building them up using the root skeleton, rather than isolating everything behind a component, therefore making it super hard to customise and build upon.

It makes sense. I thought to make these (image, video, card, list & testimonial) components based on the UX, to make some easiness for the usage.

but I might be wrong, for Card, List & Testimonial --- I can make it using the root skeleton, but I saw one thing in that div tag is used more than root skeleton if used that way.

@SutuSebastian --- please suggest, and guide me.

SutuSebastian commented 3 months ago

also, the image placeholder example looks different

flowbite-react

Screenshot 2024-03-14 at 11 15 31

flowbite

Screenshot 2024-03-14 at 11 15 36
dhavalveera commented 3 months ago

also, the image placeholder example looks different

flowbite-react

Screenshot 2024-03-14 at 11 15 31

flowbite

Screenshot 2024-03-14 at 11 15 36

Fixed!.

rluders commented 3 months ago

@coderabbitai review

coderabbitai[bot] commented 3 months ago

[!WARNING]

Rate Limit Exceeded

@rluders has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 49 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 31c9d9d5896bab360d8da04b92d21afc0620516f and 17118071b0aeae1eff97cb0dc136f51c5278fe7e.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.