Closed dhavalveera closed 3 months ago
Run & review this pull request in StackBlitz Codeflow.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
flowbite-react | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 14, 2024 10:06am |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.70%. Comparing base (
7461173
) to head (1711807
). Report is 201 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
on dark mode the root skeleton doesn't seem to work properly:
![]()
also, for the skeleton examples (image, video, card, list, testimonial) i was thinking of building them up using the root skeleton, rather than isolating everything behind a component, therefore making it super hard to customise and build upon.
It makes sense. I thought to make these (image, video, card, list & testimonial) components based on the UX, to make some easiness for the usage.
but I might be wrong, for Card, List & Testimonial --- I can make it using the root skeleton, but I saw one thing in that div tag is used more than root skeleton if used that way.
@SutuSebastian --- please suggest, and guide me.
also, the image placeholder
example looks different
flowbite-react
flowbite
also, the
image placeholder
example looks differentflowbite-react
![]()
flowbite
![]()
Fixed!.
@coderabbitai review
[!WARNING]
Rate Limit Exceeded
@rluders has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 49 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 31c9d9d5896bab360d8da04b92d21afc0620516f and 17118071b0aeae1eff97cb0dc136f51c5278fe7e.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
This Pull Request introduces Skeleton Loading components to Flowbite-React, leveraging the Flowbite package. Skeleton Loading provides users with a seamless loading experience by displaying placeholders while content is being fetched or loaded. This enhancement includes various Skeleton components such as Skeleton, Skeleton Video, Skeleton Image, Skeleton Card, Skeleton List, and Skeleton Testimonial, ensuring a consistent loading UI across different types of content. With these additions, users will enjoy smoother transitions and improved usability, enhancing the overall user experience of Flowbite-React applications.
Pardon me for the variable names, please suggest a better naming convention.