Open MiroslavPetrik opened 3 months ago
<Button color="failure" isProcessing />
The internal Spinner has the default color.
The internal Spinner has the darker shade of the button color.
The Spinner looks off, as it appears unstyled. The original flowbite does have only the default color button in loading mode, so this is undefined, but I believe it's best to style it.
I would use the theme prop, and supply a map of darker colors, e.g. instead of the default 600 I would use 800:
theme
600
800
const innerSpinnerTheme: FlowbiteSpinnerTheme = { color: { failure: 'fill-red-800', gray: 'fill-gray-800', info: 'fill-cyan-800', pink: 'fill-pink-800', purple: 'fill-purple-800', success: 'fill-green-800', warning: 'fill-yellow-800', }, } // Button.tsx <Spinner color={color} theme={innerSpinnerTheme} />
Steps to reproduce
Current behavior
The internal Spinner has the default color.
Expected behavior
The internal Spinner has the darker shade of the button color.
Context
The Spinner looks off, as it appears unstyled. The original flowbite does have only the default color button in loading mode, so this is undefined, but I believe it's best to style it.
Solution
I would use the
theme
prop, and supply a map of darker colors, e.g. instead of the default600
I would use800
: