Closed chunkerchunker closed 3 months ago
Run & review this pull request in StackBlitz Codeflow.
Latest commit: 8f1b29613526040af89cc63ca94af01528077b22
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
flowbite-react | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 1, 2024 3:22am |
flowbite-react-storybook | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 1, 2024 3:22am |
This update refines the import approach for ButtonProps
and enhances the logic for determining button positions within groups, ensuring a smoother and more intuitive grouping of buttons in the UI component.
File Path | Change Summary |
---|---|
.../Button/ButtonGroup.tsx |
Modified ButtonProps import and refactored button positioning logic. |
In the realm of code where buttons align,
A rabbit hopped, making designs refine.
With each leap and bound, errors unwind,
Grouped buttons in harmony, you'll find.
🐰✨
"To group or not?" No more debate,
For CodeRabbit's touch makes all integrate.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
formatting
Apologies, fixed.
Summarize the changes made and the motivation behind them.
This change fixes the following issue that was introduced recently in commit d0dc810:
ButtonGroup was adding positionInGroup to all children rather than just Buttons. For example, in the following, both the Buttons and the child spans get positionInGroup props:
This results in a React warning: “Warning: React does not recognize the
positionInGroup
prop on a DOM element...”The review comment on the original commit hints at this issue as well:
https://github.com/themesberg/flowbite-react/pull/1273#issuecomment-1991553683
Summary by CodeRabbit