Open dhavalveera opened 2 months ago
Latest commit: b116788be57f7bc5a89631c748db437df899d850
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
flowbite-react | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 17, 2024 5:12am |
flowbite-react-storybook | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 17, 2024 5:12am |
The update involves a semantic change in the custom theme for buttons, where the color key "primary" is renamed to "failure." This change affects the button color styling specifically in the MyPage
component.
File Path | Change Summary |
---|---|
apps/web/content/docs/.../theme.mdx |
Renamed color key from "primary" to "failure" in button theme |
🐇✨ In the land of code where themes intertwine, A rabbit hopped through, making changes divine. From 'primary' to 'failure', a key did shift, In buttons it changed, giving themes a lift. Hopping away, the rabbit felt slick, Leaving behind code, wonderfully quick. 🌟🐰
apps/web/content/docs/customize/theme.mdx (3)
`42-42`: The update to use the color key "failure" is clear and aligns well with the intended semantic meaning. --- `50-50`: Correct usage of the "failure" color key in the `Button` component, consistent with the custom theme settings. --- `66-72`: The definition and application of the custom theme with the "failure" color key are correctly implemented.
I also have this issue... need to manage all colors manually... 🥲 @SutuSebastian
There is work planned to introduce the primary
color in tailwind.config.(js/ts/cjs/mjs)
file, so I'm just gonna leave this here for now.
This PR is fixing a documentation error specifically for the
Button
component. As we don't have anycolor
option called asPrimary
the below is the fix of the documentation with the correct color option in the custom theme option.
Summary by CodeRabbit