Closed SutuSebastian closed 2 months ago
Latest commit: 34d9bff104ba55f481775eb852a4835ac1758c65
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
flowbite-react | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 23, 2024 0:14am |
flowbite-react-storybook | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 23, 2024 0:14am |
The update brings new functionality to the layout.tsx
file, enhancing header handling and selectively including a script based on the page context. It refines the import setup for headers and introduces logic to conditionally determine the inclusion of the FathomScript
on example pages.
File Path | Changes Summary |
---|---|
.../layout.tsx |
Added header import; Conditional inclusion of FathomScript on example pages. |
🐇✨ In the code's garden, changes bloom, A rabbit hops through, room by room. With headers new and scripts so bright, Only on example pages, they alight. Hop, skip, a commit, then merge, In digital meadows, we surge. 🌼🚀
apps/web/components/fathom-script.tsx (1)
`5-12`: The conditional logic to exclude analytics on the examples page is implemented correctly and efficiently.apps/web/app/layout.tsx (1)
`54-60`: > :memo: **NOTE** > This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [57-69] The integration of `FathomScript` in the `RootLayout` function is done correctly, ensuring that analytics scripts do not load prematurely and affect page performance.
As discussed with @zoltanszogyenyi .
Changes
examples
page leading to page-load-count inception due to code preview examples iframeSummary by CodeRabbit