search

themesberg / flowbite-react

Official React components built for Flowbite and Tailwind CSS
https://flowbite-react.com
MIT License
1.77k stars 395 forks source link

fix: fixed the Tabs attribute from style to variant #1405

Closed dhavalveera closed 1 week ago

dhavalveera commented 1 month ago

Issue Reference #1256

this PR fixes the omitting attribute of style and now it's been replaced with variant attribute in order to allow the usage of style attribute.

Summary by CodeRabbit

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: d14a5242ff420b0f39663b3347c54350429320cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | flowbite-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 3:05am
flowbite-react-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 3:05am
coderabbitai[bot] commented 1 month ago

Walkthrough

The recent updates involve renaming the style prop to variant in the <Tabs> component across various files and examples. This change enhances clarity and allows the use of the style attribute for other purposes. The modifications span documentation, examples, and component definitions, ensuring consistency throughout the codebase.

Changes

File(s) Change Summary
apps/web/content/docs/components/tabs.mdx Updated <Tabs> prop from style to variant for different tab styles.
apps/web/examples/tabs/tabs.fullWidth.tsx Changed style attribute to variant, specifying fullWidth for the Tabs component.
apps/web/examples/tabs/tabs.root.tsx Updated style attribute to variant for consistency in the Tabs component.
apps/web/examples/tabs/tabs.stateOptions.tsx Changed style attribute to variant in the Tabs component.
apps/web/examples/tabs/tabs.withIcons.tsx Updated style attribute to variant in the Tabs component.
apps/web/examples/tabs/tabs.withPills.tsx Changed style attribute to variant, specifying pills style in the Tabs component.
apps/web/examples/tabs/tabs.withUnderline.tsx Updated style attribute to variant, specifying underline style in the Tabs component.
packages/ui/src/components/Tabs/Tabs.stories.tsx Renamed style property to variant in Tabs component stories.
packages/ui/src/components/Tabs/Tabs.tsx Renamed styles to variant in the FlowbiteTabsTheme interface and updated references accordingly.
packages/ui/src/components/Tabs/theme.ts Replaced styles property with variant in tablist, tabitem, and tabitemcontainer styles.
.changeset/forty-pumpkins-grow.md Introduced a patch renaming style to variant in the flowbite-react package for the Tabs component.

In code's realm, a change was made, Style to variant, a switch displayed. Tabs now gleam with clarity bright, A rabbit's touch, in code's twilight. 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
SutuSebastian commented 1 month ago

Looks good, only thing left is to create a changeset (patch)

dhavalveera commented 1 month ago

Looks good, only thing left is to create a changeset (patch)

Pardon!. but can you help from where & how I need to create this changeset (patch)?

dhavalveera commented 1 month ago

Looks good, only thing left is to create a changeset (patch)

Please have a look, the changeset I've added is correct...