Closed SutuSebastian closed 1 week ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
flowbite-react | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 20, 2024 11:08am |
flowbite-react-storybook | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 20, 2024 11:08am |
Latest commit: 4f1f030cf939cb896f430059c41c54472e8ae49a
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
[!WARNING]
Review failed
The pull request is closed.
This update refines the flowbite-react
timeline component by decoupling TimelineContent
base styles from horizontal
and vertical
styles. Tests now validate class application based on the timeline mode. These changes enhance code maintainability and ensure proper style application in different layout modes.
File Path | Change Summary |
---|---|
.../Timeline/Timeline.spec.tsx | Added imports for Flowbite and CustomFlowbiteTheme , and new tests for horizontal and vertical content rendering. |
.../Timeline/TimelineContent.tsx | Updated FlowbiteTimelineContentTheme and modified className to conditionally apply styles based on mode. |
.../Timeline/theme.ts | Adjusted styling classes, separating base, horizontal, and vertical properties in content.root . |
In the land of code where timelines grow,
Content styles now deftly flow. 🌿
Horizontal and vertical with grace,
Each mode finds its rightful place.
Tests are here to dance and show,
The elegance offlowbite-react
aglow.✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary
This is a port of #1224 PR to the new monorepo structure, thanks @revuwem!
Changes
TimelineContent
base styles from horizontal/vertical stylesAPI changes
The theme now supports optional
root.vertical
androot.horizontal
props.Summary by CodeRabbit
Bug Fixes
Tests