Closed cintek closed 2 months ago
The changes involve updates to the CSS classes for the disabled
state in two Svelte components: Helper.svelte
and Label.svelte
. Both components had their original CSS classes modified to include additional styles, specifically grayscale
and contrast-50
, enhancing the visual representation of disabled elements.
File | Change Summary |
---|---|
src/lib/forms/Helper.svelte | Updated the CSS class for the disabled state from 'text-gray-400 dark:text-gray-500' to 'text-gray-400 dark:text-gray-500 grayscale contrast-50' . |
src/lib/forms/Label.svelte | Modified the disabled property in the style object from 'text-gray-400 dark:text-gray-500' to 'text-gray-400 dark:text-gray-500 grayscale contrast-50' . |
Label.svelte
and Helper.svelte
involve modifications to the CSS classes for the disabled
state, relevant to styling adjustments in the Toggle.svelte
component.Input.svelte
component, but the styling and class management changes in Label.svelte
and Helper.svelte
may relate to overall form component styling, including inputs.🐇 In the meadow where colors play,
The labels and helpers shine today.
With grayscale hues and contrast bright,
Disabled states now look just right!
A hop, a skip, a joyful cheer,
For styles that bring us all good cheer! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@cintek is attempting to deploy a commit to the Themesberg Team on Vercel.
A member of the Team first needs to authorize it.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
flowbite-svelte | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 24, 2024 3:20pm |
Before:
After:
This PR makes it easier to distinguish between the active and the disabled state. When only the text has a different color but the checkbox still has the same users may think that a disabled checkbox can be toggled, especially if they don't have another checkbox to compare. When changing the color of both we ensure that users correctly interpret the state.
Furthermore, if you don't use a label it was not possible to see if a checkbox is disabled at all. With this change it is possible to detect the change.
Solves #1446.
Summary by CodeRabbit