search

themesberg / flowbite-svelte

Official Svelte components built for Flowbite and Tailwind CSS
https://flowbite-svelte.com
MIT License
2.24k stars 274 forks source link

ToggleDarkTheme should not use localStorage #540

Closed shinokada closed 1 year ago

shinokada commented 1 year ago

Describe the bug

ToggleDarkTheme should not use localStorage

Flowbite-Svelte uses localStorage in the DarkMode component. We need to show cookie consent in order to be compliant with the General Data Protection Regulation (GDPR). And the popup can be added for the message in the DarkMode component.

Reproduction

DarkMode module.

Flowbite version and System Info

N/A
zoltanszogyenyi commented 1 year ago

Hey @shinokada,

I wouldn't rush into this, not yet. All of the major libraries and frameworks do this without a consent opt-in and I will also contact a GDPR lawyer to sort things out - so please hold off the issue for a few days.

Additionally, even if we are to implement some form of consent it would probably be better to show it in the form of a tooltip or popover on top of the theme switcher when the user hovers - there is no need to show a whole cookie modal just for this.

This would severely affect the UI/UX of the website for a GDPR compliance reason that is not yet sorted out.

Thanks, Zoltan

zoltanszogyenyi commented 1 year ago

Hey @shinokada,

It looks like we will hold this off for now. One of the creators of Material UI also stepped into the discussion and advised us that it does not in fact violate the GDPR laws - considering that every other major CSS framework does the same thing we won't be removing this from the localStorage or showing a cookie modal unless we set other cookies.

https://github.com/themesberg/flowbite-react/issues/546

Cheers, Zoltan

shinokada commented 1 year ago

Thanks, @zoltanszogyenyi . I close the issue for now.