feat: inherit attrs to `Textarea` + fix `Input` label color

themesberg / flowbite-vue

Official Vue 3 components built for Flowbite and Tailwind CSS

https://flowbite-vue.com

MIT License

739 stars 117 forks source link

feat: inherit attrs to `Textarea` + fix `Input` label color #245

Closed AnotiaWang closed 9 months ago

AnotiaWang commented 10 months ago

~~Added the following attributes to Textarea:~~

disabled

form

maxlength

minlength

required

readonly

~~wrap~~

Update: used inheritAttrs: false in defineOptions

Other information: The label text color of Textarea is different from Input in dark mode, with text-gray-300 vs text-white. Is this by design?

Tomek-N commented 10 months ago

In terms of different colors in labels... our single source of truth should be official Flowbite documentation... input, textarea... and there both are text-gray-900 dark:text-white... so it's a bug on our side.

AnotiaWang commented 10 months ago

Okay then. Should I fix it in this PR, or maybe move it to a new one?

Tomek-N commented 10 months ago

since it's not approved yet... maybe add it to this one... it's a small change so it shouldn't mess up much ;)

cogor commented 9 months ago

LGTM