themesberg / flowbite-vue

Official Vue 3 components built for Flowbite and Tailwind CSS

https://flowbite-vue.com

MIT License

723 stars 116 forks source link

refactor: expose `isOpen` to use in `arrow-icon` slot #256

Open bcostaaa01 opened 8 months ago

bcostaaa01 commented 8 months ago

Description

When using the custom arrow-icon slot from SidebarDropdownItem component, it is not possible to use the isOpen ref value used in the official component in the Flowbite-Vue library.

Suggested Fix

expose the isOpen ref value with defineExpose
add documentation for this

netlify[bot] commented 8 months ago

Deploy Preview for sensational-seahorse-8635f8 ready!

Name	Link
Latest commit	13ee96773ecabb2badf189e8e2dd3a4f3ccce4d6
Latest deploy log	https://app.netlify.com/sites/sensational-seahorse-8635f8/deploys/657c48e59c645a0008cd3e25
Deploy Preview	https://deploy-preview-256--sensational-seahorse-8635f8.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bcostaaa01 commented 7 months ago

@cogor what is the current status of my MR review? All the pipelines are passing, so I am just awaiting your review and merge 🙂

bcostaaa01 commented 4 months ago