search

themesberg / flowbite-vue

Official Vue 3 components built for Flowbite and Tailwind CSS
https://flowbite-vue.com
MIT License
723 stars 116 forks source link

Add autocomplete property #285

Closed hongquan closed 1 week ago

hongquan commented 3 months ago

Passthrough autocomplete to HTML elements.

Summary by CodeRabbit

netlify[bot] commented 3 months ago

Deploy Preview for sensational-seahorse-8635f8 ready!

Name Link
Latest commit e03b93be1b54ef0c9387e184ada6264882038750
Latest deploy log https://app.netlify.com/sites/sensational-seahorse-8635f8/deploys/66b31f021668af00089c1094
Deploy Preview https://deploy-preview-285--sensational-seahorse-8635f8.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hongquan commented 3 months ago

The remaining failed CI job is not related to this PR.

Sqrcz commented 2 months ago

Hey,

Before we move on... can you please remove changes to package-lock.json from this PR (since there are no changes in dependencies we don't need to change this file.

next time when working locally you can use npm ci that should not change package-lock.json and you'll be sure that you have version with exactly the same dependencies versions as production one.

And please also fix this linting error... I know it may be not something you touched... but 🙏 image

hongquan commented 2 months ago

I now rebase the PR with main branch, so package-lock.json are now just the same as main branch and no longer error with FwbFileInput.vue.

But now other errors appear, which seems to be issue of either Vue (GH 10514) or TypeScript.

coderabbitai[bot] commented 1 week ago

Walkthrough

This update introduces an autocomplete property across the FwbInput, FwbSelect, and FwbTextarea components, enhancing their configurability for user input behavior. The new optional property allows developers to define how browser autocomplete functions, with a default value of 'off'. Additionally, minor formatting improvements were made in several documentation components. These changes enhance usability and maintainability across the board, aligning with web standards and improving the overall user experience.

Changes

Files Change Summary
src/components/FwbInput/FwbInput.vue Added autocomplete?: CommonAutoFill to InputProps and set default to 'off'.
src/components/FwbSelect/FwbSelect.vue Added autocomplete?: CommonAutoFill to InputProps and set default to 'off'.
src/components/FwbTextarea/FwbTextarea.vue Added autocomplete?: CommonAutoFill to TextareaProps and set default to 'off'.
src/components/FwbInput/types.ts Introduced new type CommonAutoFill for managing autofill attributes.
docs/components/typography/blockquote/FwbBlockquote*.vue Adjusted indentation for better readability in multiple blockquote example files; no functional changes.

Poem

In fields of code, we hop and play,
New autocomplete makes bright our day.
Inputs and selects, oh what a thrill,
With options to guide and user’s free will.
So here’s to changes that bring us delight,
A rabbit’s cheer for input done right! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.