Closed hongquan closed 1 week ago
Name | Link |
---|---|
Latest commit | e03b93be1b54ef0c9387e184ada6264882038750 |
Latest deploy log | https://app.netlify.com/sites/sensational-seahorse-8635f8/deploys/66b31f021668af00089c1094 |
Deploy Preview | https://deploy-preview-285--sensational-seahorse-8635f8.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
The remaining failed CI job is not related to this PR.
Hey,
Before we move on... can you please remove changes to package-lock.json
from this PR (since there are no changes in dependencies we don't need to change this file.
next time when working locally you can use npm ci
that should not change package-lock.json
and you'll be sure that you have version with exactly the same dependencies versions as production one.
And please also fix this linting error... I know it may be not something you touched... but π
I now rebase the PR with main
branch, so package-lock.json are now just the same as main
branch and no longer error with FwbFileInput.vue.
But now other errors appear, which seems to be issue of either Vue (GH 10514) or TypeScript.
This update introduces an autocomplete
property across the FwbInput
, FwbSelect
, and FwbTextarea
components, enhancing their configurability for user input behavior. The new optional property allows developers to define how browser autocomplete functions, with a default value of 'off'
. Additionally, minor formatting improvements were made in several documentation components. These changes enhance usability and maintainability across the board, aligning with web standards and improving the overall user experience.
Files | Change Summary |
---|---|
src/components/FwbInput/FwbInput.vue |
Added autocomplete?: CommonAutoFill to InputProps and set default to 'off' . |
src/components/FwbSelect/FwbSelect.vue |
Added autocomplete?: CommonAutoFill to InputProps and set default to 'off' . |
src/components/FwbTextarea/FwbTextarea.vue |
Added autocomplete?: CommonAutoFill to TextareaProps and set default to 'off' . |
src/components/FwbInput/types.ts |
Introduced new type CommonAutoFill for managing autofill attributes. |
docs/components/typography/blockquote/FwbBlockquote*.vue |
Adjusted indentation for better readability in multiple blockquote example files; no functional changes. |
In fields of code, we hop and play,
Newautocomplete
makes bright our day.
Inputs and selects, oh what a thrill,
With options to guide and userβs free will.
So hereβs to changes that bring us delight,
A rabbitβs cheer for input done right! πβ¨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Passthrough
autocomplete
to HTML elements.Summary by CodeRabbit
New Features
autocomplete
property to theFwbInput
,FwbSelect
, andFwbTextarea
components, allowing users to specify autocomplete behavior for input fields.CommonAutoFill
to simplify autofill attribute handling in forms.Improvements
autocomplete
is set to'off'
, enhancing user input control.