Closed woodrunsdeep closed 1 week ago
Name | Link |
---|---|
Latest commit | ef68d30688addce1470e058e183b7a11ee68def1 |
Latest deploy log | https://app.netlify.com/sites/sensational-seahorse-8635f8/deploys/6676dd670bbda100080b21f6 |
Deploy Preview | https://deploy-preview-293--sensational-seahorse-8635f8.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Although maybe I should have used Flowbite's implementation to be in line with the core lib:
flex
on a parent and set alignment classes on a parent as wellplacement
But I think we should keep logical prop value names (top-start
, bottom-end
, etc.) instead of Flowbite's top-left
, bottom-right
cause in RTL mode top-left
will place a model to the top right corner.
@Sqrcz If my assumptions are correct please let me know and I'll do the rest.
Thanks for the fix.
Any updates on a publish timeline? This would be a nice feature for a project right now. :) Or can I update the files manually, until a new version is ready?
Thanks!
@Sqrcz @cogor
Hi. It's been a while since this PR was created. I would appreciate your feedback on it.
Thanks
@Sqrcz @cogor
Hi. It's been a while since this PR was created. I would appreciate your feedback on it.
Thanks
Sorry, unfortunately I don't have much time for OS, but I'll do a review your PR ASAP
Currently
FwbModal
doesn't have position prop to control modal's placement on the screen. This PR adds this feature taking into consideration possible usage in RTL (Right-to-Left) mode.display: block
and theposition
prop sets corresponding classes responsible for modal's alignment. Default position iscenter
.ms-auto
instead ofml-auto
.Closes: #279 #235