themesberg / flowbite

Open-source UI component library and front-end development framework based on Tailwind CSS
https://flowbite.com
MIT License
7.73k stars 725 forks source link

Flowbite integration with new Qwik version with warning #757

Closed nelsonprsousa closed 9 months ago

nelsonprsousa commented 9 months ago

Describe the bug New eslint warning with new Qwik version (1.3.1): image

To Reproduce Steps to reproduce the behavior:

  1. Integrate Flowbite with the new Qwik version

Expected behavior No warnings with default installation.

zoltanszogyenyi commented 9 months ago

Hey @nelsonprsousa,

This seems to be an ESLint warning related to Qwik and not to the Flowbite related functions.

Cheers, Zoltan

nelsonprsousa commented 9 months ago

Yes, it is a ESLint related with the integration with Qwik. However, this means that Flowbite isn't properly following Qwik's philosophy. JS should only be loaded on request, and not using useVisibleTask.

I'd not recommend this approach for Qwik apps.

cc @zoltanszogyenyi